Repository navigation
Conversation
ioigoume
marked this pull request as draft
October 21, 2026 07:24
ioigoume
changed the title
Give OidcServerException::unauthorizedClient() the message, code and parameter order it has on wip-version-7, which also follow its sibling methods here. Say in the comments what the specifications say. RFC 9700 section 2.1.2 is about access tokens in the authorization response, so it covers 'id_token token' but not 'id_token' alone, and OpenID Connect Core section 15.4 only says the authorization code flow may be appropriate for confidential clients. The option goes beyond both, and enabling it stops any confidential client which uses the implicit flow today. Replace the integration test, which CI could not run without a signing key, with unit tests pinning the whole error response, public clients, the default, and the option reaching the grant through the factory. Its cases passed once against this code, with a temporary key. tests/bootstrap.php goes back to what it was, as its additions served one local layout. Assisted-by: Claude Code (claude-opus-5-5, rework & unit tests)
cicnavi
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #362 +/- ##
============================================
+ Coverage 53.99% 54.64% +0.65%
- Complexity 1512 1516 +4
============================================
Files 141 141
Lines 6078 6097 +19
============================================
+ Hits 3282 3332 +50
+ Misses 2796 2765 -31 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On v6, this flag is the only way to stop confidential clients from using the implicit flow, because v6 has no per-client response_types or grant_types. v6 also has no Dynamic Client Registration, so the flag covers admin-created and federated clients. On v7, the flag adds to the existing controls (per-client response_types/grant_types and server-wide enabled_grant_types) rather than replacing them. Its main use there is as one server-wide switch for clients whose response_types are still empty: clients migrated from v6, or clients that registered themselves through DCR (off by default). A possible v7 follow-up: when the flag is on, DCR could reject confidential clients that ask for implicit response types, returning invalid_client_metadata, so registration and runtime behave the same.